no-confusing-non-null-assertion

Disallow non-null assertion in locations that may be confusing.

Rule Details

Using a non-null assertion (!) next to an assign or equals check (= or == or ===) creates code that is confusing as it looks similar to a not equals check (!= !==).

a! == b; // a non-null assertions(`!`) and an equals test(`==`)
a !== b; // not equals test(`!==`)
a! === b; // a non-null assertions(`!`) and an triple equals test(`===`)

❌ Incorrect

interface Foo {
  bar?: string;
  num?: number;
}

const foo: Foo = getFoo();
const isEqualsBar = foo.bar! == 'hello';
const isEqualsNum = 1 + foo.num! == 2;

✅ Correct

interface Foo {
  bar?: string;
  num?: number;
}

const foo: Foo = getFoo();
const isEqualsBar = foo.bar == 'hello';
const isEqualsNum = (1 + foo.num!) == 2;

When Not To Use It

If you don't care about this confusion, then you will not need this rule.

Further Reading

• Issue: Easy misunderstanding: "! ===" in TypeScript repo

Attributes

• ✅ Recommended
• 🔧 Fixable
• 💭 Requires type information